Skip to content

Check if license cache exists after obtaining lock #4274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Check if license cache exists after obtaining lock #4274

wants to merge 1 commit into from
+27 −14

Conversation

MarkusObendrauf
Copy link

@MarkusObendrauf MarkusObendrauf commented Apr 22, 2025 •
edited
Loading

Fixes #4273

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@MarkusObendrauf MarkusObendrauf force-pushed the cache-check branch 2 times, most recently from 5a53575 to 35bdd47 Compare April 24, 2025 11:32
@MarkusObendrauf
Check if license cache exists after obtaining lock
42e065b 
Fix: aboutcode-org#4273

Signed-off-by: Markus Obendrauf <markus.obendrauf@tngtech.com>
@MarkusObendrauf MarkusObendrauf changed the title Check if license cache exists after obtaining lock Check if license cache exists after obtaining lock #4273 Apr 24, 2025
@MarkusObendrauf MarkusObendrauf changed the title Check if license cache exists after obtaining lock #4273 Check if license cache exists after obtaining lock Apr 24, 2025
@MarkusObendrauf
Copy link
Author

MarkusObendrauf commented Apr 24, 2025 •
edited
Loading

I don't understand why test_match_has_correct_line_positions_in_automake_perl_file fails now, sorry.

Seems to pass locally for me

@MarkusObendrauf MarkusObendrauf marked this pull request as ready for review April 24, 2025 12:40
@mstykow
Copy link

mstykow commented Jun 27, 2025

@AyanSinhaMahapatra @pombredanne how can we move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne Awaiting requested review from pombredanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License cache not always reused
2 participants
@MarkusObendrauf @mstykow